kwk planned changes to this revision. kwk added a comment. In D75750#1929967 <https://reviews.llvm.org/D75750#1929967>, @jankratochvil wrote:
> On Fedora 31 x86_64 with LLDB using python3 I got: > > llvm-lit: .../llvm-monorepo2/llvm/utils/lit/lit/TestingConfig.py:102: > fatal: unable to parse config file > '.../llvm-monorepo2-clangassert/tools/lldb/test/Shell/lit.site.cfg.py', > traceback: Traceback (most recent call last): > File ".../llvm-monorepo2/llvm/utils/lit/lit/TestingConfig.py", line 89, > in load_from_path > exec(compile(data, path, 'exec'), cfg_globals, None) > File > ".../llvm-monorepo2-clangassert/tools/lldb/test/Shell/lit.site.cfg.py", line > 20, in <module> > config.lldb_enable_debuginfod = TRUE > NameError: name 'TRUE' is not defined > make[3]: *** [tools/lldb/test/CMakeFiles/check-lldb-lit.dir/build.make:58: > tools/lldb/test/CMakeFiles/check-lldb-lit] Error 2 > Right, I manually fixed it locally and have forgotton to fix it. Thank you @jankratochvil for bringing it up. > It helped to change: > > - set(Debuginfod_FOUND TRUE) > + set(Debuginfod_FOUND 1) I'm sure this helps but we have a better way by using `llvm_canonicalize_cmake_booleans` in CMake. I did use this before for minidebuginfo and LZMA integration but the place in which I've put it was moved around which is why I needed some time. Expect a fix soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
