mib marked an inline comment as done. mib added inline comments.
================ Comment at: lldb/source/Expression/DWARFExpression.cpp:2164 + unsigned int curr_scalar = curr_piece.GetScalar().UInt(); + curr_scalar = curr_scalar << curr_width; + bit_pieces.resize(curr_width + piece_byte_size * 8); ---------------- aprantl wrote: > how do you know the `unsigned int` is large enough for this operation? TBH, I just chose the same return type as GetScalar::UInt. I’ll change it to GetScalar::UInt128 with an llvm::APInt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76449/new/ https://reviews.llvm.org/D76449 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
