HsiangKai added a comment. In D74023#1948388 <https://reviews.llvm.org/D74023#1948388>, @MaskRay wrote:
> The code generally looks good. For unittests, I think we can either make > llvm-readobj -A canonical or the unittests canonical. If we decide to place > tests on one place, we should delete most tests on the other side. > > My current preference is that we use more of unittests and leave the minimum > to `test/llvm-readobj/ELF/{ARM,RISCV}/` Agree. I will remove redundant tests in test/tools/llvm-readobj/ELF/{ARM,RISCV}/. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74023/new/ https://reviews.llvm.org/D74023 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits