clayborg added a comment.
Looks good as long as with we have "llvm::Optional<llvm::StringRef>
request_path = {}" in the arguments for a function, that "{}" will turn into
llvm::None and not an empty StringRef? Unclear to me. As long as this is what
is happening and as long is this coding convention is used elsewhere in llvm
(using "{}" instead of "llvm::None") I am ok. Pavel?
================
Comment at: lldb/tools/lldb-vscode/JSONUtils.h:204
+void AppendBreakpoint(lldb::SBBreakpoint &bp, llvm::json::Array &breakpoints,
+ llvm::Optional<llvm::StringRef> request_path = {});
----------------
s/{}/llvm::None/ if {} doesn't construct to llvm::None?
================
Comment at: lldb/tools/lldb-vscode/JSONUtils.h:222
+CreateBreakpoint(lldb::SBBreakpoint &bp,
+ llvm::Optional<llvm::StringRef> request_path = {});
----------------
s/{}/llvm::None/ if {} doesn't construct to llvm::None
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76968/new/
https://reviews.llvm.org/D76968
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
