labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Thanks for doing this. This looks fine to me. @dblaikie, @jhenderson, do you 
have any additional comments?



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnitIndex.cpp:38-39
+  if (IndexVersion == 5) {
+    assert(Kind >= DW_SECT_INFO && Kind <= DW_SECT_RNGLISTS &&
+           Kind != DW_SECT_EXT_TYPES);
+    return static_cast<uint32_t>(Kind);
----------------
maybe a small helper like `isKnownSectionKind` ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75929/new/

https://reviews.llvm.org/D75929



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to