kwk accepted this revision.
kwk added a comment.
This revision is now accepted and ready to land.
No need to split this into multiples revisions. It is just a rewrite of some
odd nesting.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2943
+ // Make sure the decl contexts match all the way up
+ if (dwarf_decl_ctx != type_dwarf_decl_ctx)
+ continue;
----------------
jankratochvil wrote:
> kwk wrote:
> > This looks like a logic change and I wonder if it should go in a separate
> > patch, maybe?
> This should be NFC, do I miss something?
> From:
> ```
> if (a == b) {
> c;
> }
> ```
> The patch changes it to:
> ```
> if (a != b)
> continue;
> c;
> ```
>
Ah, now I see that it was previously a block on the right side of the diff :).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77326/new/
https://reviews.llvm.org/D77326
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
