clayborg added a comment.

In D77444#1963354 <https://reviews.llvm.org/D77444#1963354>, @labath wrote:

> In D77444#1962952 <https://reviews.llvm.org/D77444#1962952>, @clayborg wrote:
>
> > The biggest issue is maintaining the API. We can't add anything to 
> > SBCommandPluginInterface
>
>
> If we're going to be adding a new inheritable class for this feature, I'd 
> recommend adding about half a dozen or so dummy virtual methods to it so we 
> reserve vtable space for future expansion.


I second that!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77444/new/

https://reviews.llvm.org/D77444



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to