shafik added inline comments.
================ Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:103 + // Helper iterator for the 'equal_range' method. + class CString_iterator { + public: ---------------- `CStringIterator`? ================ Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:134 + private: + const UniqueCStringMap &m_map; + const Entry *m_entry_ptr; ---------------- It feels like this should be a pointer, `m_entry_ptr` is a pointer already and most uses in the class use the pointer value already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits