labath added a comment.
Thanks. This looks fine, just a question about the placement of the lldbconfig
module.
================
Comment at: lldb/CMakeLists.txt:130
+ "${LLDB_SOURCE_DIR}/bindings/python/lldbconfig.py"
+ "${python_build_path}/lldbconfig/__init__.py")
+
----------------
If we're not going to ship this file, should we place it under
`packages/Python/...` (I'm sure there is some place we could put it where it
would already be in `sys.path` ? That way it would not be accessible from
regular lldb runs, only for those from dotest, which would decrease the
likelyhood of lldb suddenly stopping to work after being installed.
================
Comment at: lldb/bindings/python.swig:131
%pythoncode%{
+INITIALIZE = True
+try:
----------------
Maybe `_initialize` (the convention for "private" variables in python)?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77661/new/
https://reviews.llvm.org/D77661
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
