efriedma added a comment.
Looks right, generally.
================
Comment at: llvm/include/llvm-c/Core.h:163
+ * value of enum variants after the removal of LLVMVectorTypeKind
+ */
+ LLVMMetadataTypeKind = LLVMPointerTypeKind + 2, /**< Metadata */
----------------
The C API is officially not ABI-stable anymore across versions, No reason to
have a gap like this.
================
Comment at: llvm/lib/ExecutionEngine/ExecutionEngine.cpp:1011
llvm_unreachable("Unknown constant pointer type!");
- }
- break;
+ } break;
----------------
?
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp:481
}
- } else if (ArgType->getTypeID() == Type::VectorTyID) {
+ } else if (ArgType->getTypeID() == Type::FixedVectorTyID) {
Type *IType = NULL;
----------------
Please fix this to use isa<> while you're here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77587/new/
https://reviews.llvm.org/D77587
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
