labath added a comment.
Heh.. I wasn't an attempt expecting a fully generic solution. Since we don't
invoke dotest.py manually these days (we have lldb-dotest for that) making a
separate argument specifically for this plugin would be just fine. However, I
don't see anything inherently wrong with this generic approach, so I guess we
can leave it. The main think I don't like is the introduction of the skipping
code into the base test class. These classes are already more complicated than
they ought to be, so I'd like to avoid adding things to them, if those things
can be implemented elsewhere.
================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:736-738
+ if self.plugin and self.plugin not in configuration.enabled_plugins:
+ self.skipTest("The '" + self.plugin + "' plugin is not enabled")
+
----------------
Let's put this stuff in `TestIntelPTSimpleBinary` for now -- it can be moved
into a separate base class (along with other common code) once we have more of
these tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77452/new/
https://reviews.llvm.org/D77452
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
