labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

In D77588#1972418 <https://reviews.llvm.org/D77588#1972418>, @JDevlieghere 
wrote:

> In D77588#1971345 <https://reviews.llvm.org/D77588#1971345>, @labath wrote:
>
> > Ok, I'm starting to understand what's going on here. This patch looks 
> > mostly fine, but IIUC, it won't really do anything until the subsequent 
> > patch lands as that is what implements the inline/api/passive replay. I'm 
> > going to start looking at that other patch now.
>
>
> It's sufficient for stage one, i.e. capture the test suite and use the driver 
> (active replay), but it also contains the necessary changes for stage 2 
> (passive replay). I could've split it up in two patches but given that the 
> changes are so similar that didn't seem worth it.


Ah, ok. I can live with that.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77588/new/

https://reviews.llvm.org/D77588



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to