a_sidorin accepted this revision. a_sidorin added a comment. Hello Shafik! The patch looks good, I only have a few stylish nits.
================ Comment at: clang/unittests/AST/ASTImporterTest.cpp:5964 + new SourceWithCompletedTagList(CompletedTags); + clang::ASTContext &context = FromTU->getASTContext(); + context.setExternalSource(std::move(source)); ---------------- Context (starting with capital). ================ Comment at: clang/unittests/AST/ASTImporterTest.cpp:5980 + // Import the definition of the created class. + llvm::Error err = findFromTU(Record)->Importer->ImportDefinition(Record); + EXPECT_FALSE((bool)err); ---------------- Err (starting with capital). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78000/new/ https://reviews.llvm.org/D78000 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
