labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good. Let's just wait a while to see if Fred has any comments. If you
haven't already, you can use that time to get commit access. :)
================
Comment at: lldb/source/Utility/UUID.cpp:66-67
uuid_bytes.clear();
while (!p.empty()) {
- if (isxdigit(p[0]) && isxdigit(p[1])) {
+ if (p.size() >= 2 && isxdigit(p[0]) && isxdigit(p[1])) {
int hi_nibble = xdigit_to_int(p[0]);
----------------
I guess now obsoletes Fred's D80807.
(Btw, I actually liked how Fred's solution rejects strings which end in a
trailing dash.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80755/new/
https://reviews.llvm.org/D80755
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
