labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land.
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:733 DWARFAttributes attributes; - GetAttributes(cu, attributes); + GetAttributes(cu, attributes, 0 /* curr_depth */); return GetParentDeclContextDIE(cu, attributes); ---------------- I guess this could keep calling the public version of this function without the extra argument. ================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:783 DWARFAttributes attributes; - GetAttributes(cu, attributes); + GetAttributes(cu, attributes, 0 /* curr_depth */); return GetQualifiedName(cu, attributes, storage); ---------------- and this too(?) ================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h:182 + uint32_t curr_depth) + const; // "curr_depth" for internal use only, don't set this yourself!!! }; ---------------- That comment is probably not useful anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81423/new/ https://reviews.llvm.org/D81423 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits