vsk added inline comments.

================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1750
+        # (unique) test name is used instead.
+        inline_name = None
+        for attrname, attrvalue in attrs.items():
----------------
Is `inline_suffix = attrs.get('__inline_name__')` no good?


================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1778
 
-                    method_name = attrname + "_" + cat
+                    test_name = inline_name if inline_name else attrname
+                    method_name = test_name + "_" + cat
----------------
Would it be all right to unconditionally set `method_name = name + attrname + 
cat`?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81516/new/

https://reviews.llvm.org/D81516



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to