labath marked an inline comment as done.
labath added inline comments.

================
Comment at: lldb/test/Shell/Unwind/eh-frame-augment-noop.test:18
+target modules show-unwind -n foo
+# CHECK: Asynchronous (not restricted to call-sites) UnwindPlan is 'eh_frame 
CFI'
+# CHECK: eh_frame augmented UnwindPlan:
----------------
JDevlieghere wrote:
> On Darwin this returns 
> ```Asynchronous (not restricted to call-sites) UnwindPlan is 'assembly insn 
> profiling'```
> 
> I've skipped the test in b4180fe477bfe302778aaceee65faf69c5e7be76
Thanks. It looks like what happens here is that when targetting mac, clang 
additionally emits unwind info in the compact unwind form and the linker then 
drops the eh_frame info for these functions. There doesn't seem to be a way to 
prevent the compact unwind generation (besides generating unwind info that 
cannot be translated into the compact format).

So, it seems skipping the test is the right thing to do here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82378/new/

https://reviews.llvm.org/D82378



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to