[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3424
+    if (Host::IsProcessTranslated(process_info)) {
+      FileSpec 
rosetta_debugserver("/Library/Apple/usr/libexec/oah/debugserver");
+      debugserver_launch_info.SetExecutableFile(rosetta_debugserver, false);
----------------
I don't think this is a particularly good abstraction, as the debugserver path 
is still left here, and the path is definitely os- and arch-specific. It would 
be better if the API returned the path to the debugserver-to-be-used instead.

Bonus points if you can also hide the `DEBUGSERVER_BASENAME` logic from 
GDBRemoteCommunication.cpp into the same API.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82813/new/

https://reviews.llvm.org/D82813



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits