teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM with some minor nits.
================
Comment at: lldb/include/lldb/API/SBBreakpoint.h:108
+ SBError AddNameWithErrorHandling(const char *new_name);
+
----------------
I wish we had some documentation when adding a name could fail (e.g. empty name
string?) But we can also add this all later as most of this stuff needs
documentation.
================
Comment at:
lldb/test/API/functionalities/breakpoint/breakpoint_names/TestBreakpointNames.py:146
+ success = bkpt.AddNameWithErrorHandling(bad_name)
+ self.assertTrue(success.Fail(),"We allowed an illegal name:
%s"%(bad_name))
bp_name = lldb.SBBreakpointName(self.target, bad_name)
----------------
I think we usually put spaces around operators/string literals.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82879/new/
https://reviews.llvm.org/D82879
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
