JDevlieghere added a comment. In D83815#2153459 <https://reviews.llvm.org/D83815#2153459>, @labath wrote:
> In D83815#2153438 <https://reviews.llvm.org/D83815#2153438>, @JDevlieghere > wrote: > > > In D83815#2152688 <https://reviews.llvm.org/D83815#2152688>, @labath wrote: > > > > > > > > > > > Given that we were already creating a process group on fork, I'll keep the > > change on line 902 that kills the process group instead of just the pid. > > > That seems ok -- all of those arguments (except maybe the last one) don't > really apply there. Though I am tempted to remove the setpgid call from the > forking method too (or even deleting the entire forking method). :P You got me at "delete the entire [thing]" ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83815/new/ https://reviews.llvm.org/D83815 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
