clayborg added inline comments.
================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1576
+}
+void response_runInTerminal(const llvm::json::Object &reverseRequest) {
+ g_vsc.is_attach = true;
----------------
wallace wrote:
> mention here that VSCode doesn't respond back the pid of the target, so we
> can only attach by process name, which is already set up in the
> request_launch method
The response has the process ID of what we need to attach to right? Why do we
need to do this by name?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84974/new/
https://reviews.llvm.org/D84974
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
