JDevlieghere added inline comments.
================
Comment at:
lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py:706
self._pump_queues,
- self.DEFAULT_TIMEOUT,
+ self.DEFAULT_TIMEOUT * 12,
self.logger)
----------------
I see the problem, we're trying to process all the entries in the sequence in
the timeout for a single packet. Rather than an arbitrary multiplier we should
use the number of entries in the sequence. Let's define `__len__` in
`GdbRemoteTestSequence`
```
def __len__(self):
return len(self.entries)
```
and then multiply the timeout by the length of the sequence:
```self.DEFAULT_TIMEOUT * len(self.test_sequence)```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85514/new/
https://reviews.llvm.org/D85514
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
