labath added a comment. In D86110#2224163 <https://reviews.llvm.org/D86110#2224163>, @dblaikie wrote:
> In D86110#2223905 <https://reviews.llvm.org/D86110#2223905>, @labath wrote: > >> This sounds perfectly reasonable to me. The offsets are present in memory >> already so there's no point in storing them in a vector as well. > > Thanks for taking a look! I'll take this as approval and commit soon. The patch had a WIP label, so I was only looking/commenting on the high-level idea. But after looking at the implementation more closely, I think that looks good too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86110/new/ https://reviews.llvm.org/D86110 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
