teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land.
FWIW, I actually think this patch itself is perfectly fine. As these messages are only displayed when an assert failed they should be worded with the assumption that the assert did indeed fail. It would be nice to reword all the other messages around this change to also follow this style, but I'm not a fan of signing up others for tedious work and this is a step in the right direction, so LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86603/new/ https://reviews.llvm.org/D86603 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
