JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.
================
Comment at: lldb/source/Utility/Reproducer.cpp:337
+ } else {
+ llvm::consumeError(symbol_files.takeError());
+ }
----------------
teemperor wrote:
> Maybe log the error to llvm::errs? Or is there no symbol-files.yaml when the
> replay doesn't involve symbol files, so this is expected?
Correct, the symbol files are optional.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86497/new/
https://reviews.llvm.org/D86497
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
