DavidSpickett marked 3 inline comments as done. DavidSpickett added a comment.
In D87442#2273064 <https://reviews.llvm.org/D87442#2273064>, @omjavaid wrote: > This seems fine to me with some minor nits. Also do you plan on writing a > Linux API test for this which test memory regions on Linux? I couldnt locate > one already written. There are some tests in test/API/tools/lldb-server/TestLldbGdbServer.py that parse region packets manually (e.g. qMemoryRegionInfo_reports_code_address_as_executable) but they're not using the API. There is no test for "memory region" or the API. I'll add some to test/API/linux/, one for Kernels with smaps, one without. (so you'll only run one or the other per platform) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87442/new/ https://reviews.llvm.org/D87442 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
