clayborg added inline comments.
================
Comment at: lldb/include/lldb/Symbol/ObjectFile.h:692
+ return MachOCorefileAllImageInfos();
+ }
+
----------------
basically all of the code from ProcessMachCore.cpp lines 421-455 can be moved
into:
```
llvm::Error ObjectFileMachO::LoadCoreFileImages(lldb_private::Target &target);
```
And it can GetOrLoad images directly into the target and set the right load
addresses. Then none of the mach-o specifics need to be exposed here.
================
Comment at: lldb/include/lldb/Symbol/ObjectFile.h:703
+ /// unavailable.
+ virtual std::vector<UUID> GetCorefileExecutingUUIDs() {
+ return std::vector<UUID>();
----------------
This function probably isn't needed if we put a flag into the all image infos
that is saved in the other load command. Inlined comments below will detail
where I was thinking.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88387/new/
https://reviews.llvm.org/D88387
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
