labath added a comment.

Not long ago. I added a `MCBasedABI` class which makes this goo mostly 
disappear as it gets its information from llvm MC layer. I haven't converted 
the mips abi due to a combination of being preempted by higher priority task, 
not having a mips machine to test on, and this code not being particularly 
egregious.

But if anyone wants to try this (and better yet, has ability to test it), I 
would strongly encourage converting these classes to an MCBasedABI. The only 
gotcha there is that the names of registers used by llvm mc and lldb/other 
tools don't always match, so it's sometimes necessary to write a small 
translation function. But that's still better than hundreds of lines of goo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88375/new/

https://reviews.llvm.org/D88375

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to