Author: Martin Storsjö Date: 2020-10-10T20:47:40+03:00 New Revision: abaca237c519a406ab00606b0464c32079831803
URL: https://github.com/llvm/llvm-project/commit/abaca237c519a406ab00606b0464c32079831803 DIFF: https://github.com/llvm/llvm-project/commit/abaca237c519a406ab00606b0464c32079831803.diff LOG: [lldb] [Windows] Add missing 'override', silencing warnings. NFC. Also remove superfluous 'virtual' in overridden methods. Added: Modified: lldb/include/lldb/Host/windows/HostThreadWindows.h lldb/include/lldb/Host/windows/ProcessLauncherWindows.h lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.h Removed: ################################################################################ diff --git a/lldb/include/lldb/Host/windows/HostThreadWindows.h b/lldb/include/lldb/Host/windows/HostThreadWindows.h index 63d0d73faad5..a74539543aa6 100644 --- a/lldb/include/lldb/Host/windows/HostThreadWindows.h +++ b/lldb/include/lldb/Host/windows/HostThreadWindows.h @@ -26,10 +26,10 @@ class HostThreadWindows : public HostNativeThreadBase { void SetOwnsHandle(bool owns); - virtual Status Join(lldb::thread_result_t *result); - virtual Status Cancel(); - virtual void Reset(); - virtual bool EqualsThread(lldb::thread_t thread) const; + Status Join(lldb::thread_result_t *result) override; + Status Cancel() override; + void Reset() override; + bool EqualsThread(lldb::thread_t thread) const override; lldb::tid_t GetThreadId() const; diff --git a/lldb/include/lldb/Host/windows/ProcessLauncherWindows.h b/lldb/include/lldb/Host/windows/ProcessLauncherWindows.h index e765f1e9ed54..81aea5b2022a 100644 --- a/lldb/include/lldb/Host/windows/ProcessLauncherWindows.h +++ b/lldb/include/lldb/Host/windows/ProcessLauncherWindows.h @@ -18,8 +18,8 @@ class ProcessLaunchInfo; class ProcessLauncherWindows : public ProcessLauncher { public: - virtual HostProcess LaunchProcess(const ProcessLaunchInfo &launch_info, - Status &error); + HostProcess LaunchProcess(const ProcessLaunchInfo &launch_info, + Status &error) override; protected: HANDLE GetStdioHandle(const ProcessLaunchInfo &launch_info, int fd); diff --git a/lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.h b/lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.h index 732273a54c13..89888df46756 100644 --- a/lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.h +++ b/lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.h @@ -137,39 +137,41 @@ class NativeDebugDelegate : public IDebugDelegate { public: NativeDebugDelegate(NativeProcessWindows &process) : m_process(process) {} - void OnExitProcess(uint32_t exit_code) { m_process.OnExitProcess(exit_code); } + void OnExitProcess(uint32_t exit_code) override { + m_process.OnExitProcess(exit_code); + } - void OnDebuggerConnected(lldb::addr_t image_base) { + void OnDebuggerConnected(lldb::addr_t image_base) override { m_process.OnDebuggerConnected(image_base); } ExceptionResult OnDebugException(bool first_chance, - const ExceptionRecord &record) { + const ExceptionRecord &record) override { return m_process.OnDebugException(first_chance, record); } - void OnCreateThread(const HostThread &thread) { + void OnCreateThread(const HostThread &thread) override { m_process.OnCreateThread(thread); } - void OnExitThread(lldb::tid_t thread_id, uint32_t exit_code) { + void OnExitThread(lldb::tid_t thread_id, uint32_t exit_code) override { m_process.OnExitThread(thread_id, exit_code); } void OnLoadDll(const lldb_private::ModuleSpec &module_spec, - lldb::addr_t module_addr) { + lldb::addr_t module_addr) override { m_process.OnLoadDll(module_spec, module_addr); } - void OnUnloadDll(lldb::addr_t module_addr) { + void OnUnloadDll(lldb::addr_t module_addr) override { m_process.OnUnloadDll(module_addr); } - void OnDebugString(const std::string &string) { + void OnDebugString(const std::string &string) override { m_process.OnDebugString(string); } - void OnDebuggerError(const Status &error, uint32_t type) { + void OnDebuggerError(const Status &error, uint32_t type) override { return m_process.OnDebuggerError(error, type); } _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits