This revision was automatically updated to reflect the committed changes.
Closed by commit rG41185226f6d8: [lldb] Explicitly use the configuration
architecture when building test… (authored by teemperor).
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89056/new/
https://reviews.llvm.org/D89056
Files:
lldb/packages/Python/lldbsuite/test/builders/builder.py
lldb/packages/Python/lldbsuite/test/lldbtest.py
Index: lldb/packages/Python/lldbsuite/test/lldbtest.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/lldbtest.py
+++ lldb/packages/Python/lldbsuite/test/lldbtest.py
@@ -2606,6 +2606,9 @@
"""Platform specific way to build the default binaries."""
module = builder_module()
+ if not architecture and configuration.arch:
+ architecture = configuration.arch
+
dictionary = lldbplatformutil.finalize_build_dictionary(dictionary)
if self.getDebugInfo() is None:
return self.buildDefault(architecture, compiler, dictionary)
Index: lldb/packages/Python/lldbsuite/test/builders/builder.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/builders/builder.py
+++ lldb/packages/Python/lldbsuite/test/builders/builder.py
@@ -93,11 +93,7 @@
Helper function to return the key-value string to specify the
architecture
used for the make system.
"""
- arch = architecture if architecture else None
- if not arch and configuration.arch:
- arch = configuration.arch
-
- return ("ARCH=" + arch) if arch else ""
+ return ("ARCH=" + architecture) if architecture else ""
def getCCSpec(self, compiler):
"""
Index: lldb/packages/Python/lldbsuite/test/lldbtest.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/lldbtest.py
+++ lldb/packages/Python/lldbsuite/test/lldbtest.py
@@ -2606,6 +2606,9 @@
"""Platform specific way to build the default binaries."""
module = builder_module()
+ if not architecture and configuration.arch:
+ architecture = configuration.arch
+
dictionary = lldbplatformutil.finalize_build_dictionary(dictionary)
if self.getDebugInfo() is None:
return self.buildDefault(architecture, compiler, dictionary)
Index: lldb/packages/Python/lldbsuite/test/builders/builder.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/builders/builder.py
+++ lldb/packages/Python/lldbsuite/test/builders/builder.py
@@ -93,11 +93,7 @@
Helper function to return the key-value string to specify the architecture
used for the make system.
"""
- arch = architecture if architecture else None
- if not arch and configuration.arch:
- arch = configuration.arch
-
- return ("ARCH=" + arch) if arch else ""
+ return ("ARCH=" + architecture) if architecture else ""
def getCCSpec(self, compiler):
"""
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
