teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

I don't think we should re-add the bogus `RUN_SUCCEEDED` messages here. 
`self.runCmd("print tpi")` is undocumented, but still better than wrong 
documentation. Beside that this LGTM, thanks!



================
Comment at: lldb/test/API/types/TestRecursiveTypes.py:53
 
-        self.expect("print tpi")
-        self.expect("print *tpi")
+        self.runCmd("print tpi", RUN_SUCCEEDED)
+        self.runCmd("print *tpi", RUN_SUCCEEDED)
----------------



================
Comment at: lldb/test/API/types/TestRecursiveTypes.py:54
+        self.runCmd("print tpi", RUN_SUCCEEDED)
+        self.runCmd("print *tpi", RUN_SUCCEEDED)
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91206/new/

https://reviews.llvm.org/D91206

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to