tammela added a comment.

In D92249#2422205 <https://reviews.llvm.org/D92249#2422205>, @labath wrote:

> In D92249#2421639 <https://reviews.llvm.org/D92249#2421639>, @JDevlieghere 
> wrote:
>
>> It appears there are many similar calls in this file, can you update those 
>> as well?
>
> If there are many of these calls, adding a static helper function for this 
> purpose might be a good idea as well...

Yes, it looks like the same 3-line routine is being replicated across multiple 
functions. I will clean it up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92249/new/

https://reviews.llvm.org/D92249

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to