tammela added inline comments.
================ Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.h:39 llvm::Error LoadModule(llvm::StringRef filename); + llvm::Error LoadBuffer(llvm::StringRef buffer, bool pop_result = true); llvm::Error ChangeIO(FILE *out, FILE *err); ---------------- labath wrote: > This default value does not seem particularly useful. In fact, I am not sure > if this argument should even exist at all. The usage in > `IOHandlerIsInputComplete` is sufficiently unorthodox that it might be a good > idea to draw attention to the fact that something funky is happening via an > explicit pop (and maybe a comment). We can't explicitly pop, as in calling `lua_pop()`, from `ScriptInterpreterLua.cpp` because the `lua_State` is not exposed. Are you suggesting to add a method that wraps `lua_pop()` as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93481/new/ https://reviews.llvm.org/D93481 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
