augusto2112 added a comment.

I think I get your point. If we pass the extra options in the packet, the 
validation on older lldb-server versions will reject the message.

> Another option would be to have lldb-server check for environment variables 
> for default values for --waitfor-interval and --waitfor-duration. If they are 
> set, they become the new default values. Of course a user can launch the 
> lldb-server manually with the options set a different way and then attach 
> with "process connect ..." if required. But this would provide an alternate 
> way for users to control the polling and timeout.

I'll defer to you guys, since you're a lot more knowledgeable on lldb than I am 
:)

I do have another possible solution we could consider: can we create a new 
message, similar to `qVAttachOrWaitSupported`, that queries if these extra 
options are supported or not. Something like 
`qVAttachWaitExtraOptionsSupported`. We might even consider returning something 
akin to a "version number", so if we support more options in the future we can 
bump up the number.

Let me know what you think (again, I'm fine doing it either way).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93895/new/

https://reviews.llvm.org/D93895

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to