dblaikie added inline comments.
================
Comment at: lldb/include/lldb/Core/ModuleList.h:70
+class ModuleIterator
+ : public std::iterator<std::bidirectional_iterator_tag, lldb::ModuleSP> {
+public:
----------------
FWIW, std::iterator is deprecated since C++17 - probably best not to add new
uses of it. (I think the idea is that the typedefs that std::iterator provides
are no longer needed because of auto/decltype/etc, but I might be wrong there
(would have to check the iterator concepts specifications))
If you need some utility help with implementing an iterator, llvm's
iterator_facade_base might help by allowing a fairly minimal implementation to
autogenerate various symmetric members, etc.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94136/new/
https://reviews.llvm.org/D94136
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
