labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land.
================ Comment at: lldb/include/lldb/Utility/OptionDefinition.h:52 + // Must not have any bits set outside of unsigned char range + return !(short_option & ~((1 << CHAR_BIT) - 1)) && + llvm::isPrint(short_option); ---------------- Something like `llvm::is(U)Int<CHAR_BIT>(short_option)` would better convey the intention. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94917/new/ https://reviews.llvm.org/D94917 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
