labath added a comment. In D94888#2506000 <https://reviews.llvm.org/D94888#2506000>, @MaskRay wrote:
> In D94888#2505992 <https://reviews.llvm.org/D94888#2505992>, @labath wrote: > >> It looks like this is removing the ability to build libc++ tests with gcc >> (as it does not have the `-stdlib` option). While having that ability would >> be nice, I don't believe there's anyone currently using that configuration, >> so it shouldn't stand in the way of other things. But we should also update >> the python detection code then (in `canRunLibcxxTests` in >> `packages/Python/lldbsuite/test/dotest.py` -- I guess you just need to >> remove the `if os.path.isdir("/usr/include/c++/v1"):` blurb) >> >> As for testing against the system libc++ with clang, I guess that should >> still work, as the extra rpath will be just ignored in that case... > > I do not know whether the following few lines D9426 > <https://reviews.llvm.org/D9426> were intentional. I am pretty sure they were. This flag is needed to use (system) libc++ with gcc, and this was happening at a time when we were running the test suite with gcc, as it was still the default compiler for android. We weren't building libc++ in tree so this did kind of work (it looks like it doesn't work anymore -- the first problem seems to be the use of `#include_next` in libc++). > I think deleting the code until someone complains is fine? :) Deleting it should be fine -- just finish the job and remove it from dotest.py too :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94888/new/ https://reviews.llvm.org/D94888 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
