kastiglione created this revision.
kastiglione added a reviewer: jingham.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Delete unused `EnableTracer()` and `SetTracer()` functions on `Thread`. By
deleting
these, their `ThreadPlan` counterparts also become unused.
Then, by deleting `ThreadPlanStack::EnableTracer`, `EnableSingleStep` becomes
unused.
With no more callers to `EnableSingleStep`, the value `m_single_step` is always
true and
can be removed as well.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D96666
Files:
lldb/include/lldb/Target/Thread.h
lldb/include/lldb/Target/ThreadPlanStack.h
lldb/include/lldb/Target/ThreadPlanTracer.h
lldb/source/Target/Thread.cpp
lldb/source/Target/ThreadPlan.cpp
lldb/source/Target/ThreadPlanStack.cpp
lldb/source/Target/ThreadPlanTracer.cpp
Index: lldb/source/Target/ThreadPlanTracer.cpp
===================================================================
--- lldb/source/Target/ThreadPlanTracer.cpp
+++ lldb/source/Target/ThreadPlanTracer.cpp
@@ -35,11 +35,11 @@
ThreadPlanTracer::ThreadPlanTracer(Thread &thread, lldb::StreamSP &stream_sp)
: m_process(*thread.GetProcess().get()), m_tid(thread.GetID()),
- m_single_step(true), m_enabled(false), m_stream_sp(stream_sp) {}
+ m_enabled(false), m_stream_sp(stream_sp) {}
ThreadPlanTracer::ThreadPlanTracer(Thread &thread)
: m_process(*thread.GetProcess().get()), m_tid(thread.GetID()),
- m_single_step(true), m_enabled(false), m_stream_sp() {}
+ m_enabled(false), m_stream_sp() {}
Stream *ThreadPlanTracer::GetLogStream() {
if (m_stream_sp)
@@ -75,7 +75,7 @@
}
bool ThreadPlanTracer::TracerExplainsStop() {
- if (m_enabled && m_single_step) {
+ if (m_enabled) {
lldb::StopInfoSP stop_info = GetThread().GetStopInfo();
return (stop_info->GetStopReason() == eStopReasonTrace);
} else
Index: lldb/source/Target/ThreadPlanStack.cpp
===================================================================
--- lldb/source/Target/ThreadPlanStack.cpp
+++ lldb/source/Target/ThreadPlanStack.cpp
@@ -124,20 +124,6 @@
}
}
-void ThreadPlanStack::EnableTracer(bool value, bool single_stepping) {
- for (ThreadPlanSP plan : m_plans) {
- if (plan->GetThreadPlanTracer()) {
- plan->GetThreadPlanTracer()->EnableTracing(value);
- plan->GetThreadPlanTracer()->EnableSingleStep(single_stepping);
- }
- }
-}
-
-void ThreadPlanStack::SetTracer(lldb::ThreadPlanTracerSP &tracer_sp) {
- for (ThreadPlanSP plan : m_plans)
- plan->SetThreadPlanTracer(tracer_sp);
-}
-
void ThreadPlanStack::PushPlan(lldb::ThreadPlanSP new_plan_sp) {
// If the thread plan doesn't already have a tracer, give it its parent's
// tracer:
Index: lldb/source/Target/ThreadPlan.cpp
===================================================================
--- lldb/source/Target/ThreadPlan.cpp
+++ lldb/source/Target/ThreadPlan.cpp
@@ -158,8 +158,7 @@
}
lldb::StateType ThreadPlan::RunState() {
- if (m_tracer_sp && m_tracer_sp->TracingEnabled() &&
- m_tracer_sp->SingleStepEnabled())
+ if (m_tracer_sp && m_tracer_sp->TracingEnabled())
return eStateStepping;
else
return GetPlanRunState();
Index: lldb/source/Target/Thread.cpp
===================================================================
--- lldb/source/Target/Thread.cpp
+++ lldb/source/Target/Thread.cpp
@@ -1181,14 +1181,6 @@
return status;
}
-void Thread::EnableTracer(bool value, bool single_stepping) {
- GetPlans().EnableTracer(value, single_stepping);
-}
-
-void Thread::SetTracer(lldb::ThreadPlanTracerSP &tracer_sp) {
- GetPlans().SetTracer(tracer_sp);
-}
-
bool Thread::DiscardUserThreadPlansUpToIndex(uint32_t plan_index) {
// Count the user thread plans from the back end to get the number of the one
// we want to discard:
Index: lldb/include/lldb/Target/ThreadPlanTracer.h
===================================================================
--- lldb/include/lldb/Target/ThreadPlanTracer.h
+++ lldb/include/lldb/Target/ThreadPlanTracer.h
@@ -50,14 +50,6 @@
bool TracingEnabled() { return m_enabled; }
- bool EnableSingleStep(bool value) {
- bool old_value = m_single_step;
- m_single_step = value;
- return old_value;
- }
-
- bool SingleStepEnabled() { return m_single_step; }
-
Thread &GetThread();
protected:
@@ -71,7 +63,6 @@
private:
bool TracerExplainsStop();
- bool m_single_step;
bool m_enabled;
lldb::StreamSP m_stream_sp;
Thread *m_thread;
Index: lldb/include/lldb/Target/ThreadPlanStack.h
===================================================================
--- lldb/include/lldb/Target/ThreadPlanStack.h
+++ lldb/include/lldb/Target/ThreadPlanStack.h
@@ -48,10 +48,6 @@
void ThreadDestroyed(Thread *thread);
- void EnableTracer(bool value, bool single_stepping);
-
- void SetTracer(lldb::ThreadPlanTracerSP &tracer_sp);
-
void PushPlan(lldb::ThreadPlanSP new_plan_sp);
lldb::ThreadPlanSP PopPlan();
Index: lldb/include/lldb/Target/Thread.h
===================================================================
--- lldb/include/lldb/Target/Thread.h
+++ lldb/include/lldb/Target/Thread.h
@@ -1055,10 +1055,6 @@
virtual bool
RestoreThreadStateFromCheckpoint(ThreadStateCheckpoint &saved_state);
- void EnableTracer(bool value, bool single_step);
-
- void SetTracer(lldb::ThreadPlanTracerSP &tracer_sp);
-
// Get the thread index ID. The index ID that is guaranteed to not be re-used
// by a process. They start at 1 and increase with each new thread. This
// allows easy command line access by a unique ID that is easier to type than
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
