Author: Raphael Isemann Date: 2021-02-17T16:13:20+01:00 New Revision: 8bcc03767e440f229749d101f470f73b8e1cd2e5
URL: https://github.com/llvm/llvm-project/commit/8bcc03767e440f229749d101f470f73b8e1cd2e5 DIFF: https://github.com/llvm/llvm-project/commit/8bcc03767e440f229749d101f470f73b8e1cd2e5.diff LOG: [lldb][NFC] Delete deleted const char* overloads of SetValueFromString This came up during the review of D96817 because those deleted overloads force the caller to explicitly create a StringRef when passing a string literal. It seems they were added as some kind of help while migrating the code base to StringRef in D24847, but I don't think they have any use these days and make these functions awkward to use. This patch just removes all the deleted overloads. Reviewed By: tatyana-krasnukha Differential Revision: https://reviews.llvm.org/D96861 Added: Modified: lldb/include/lldb/Interpreter/OptionValueArch.h lldb/include/lldb/Interpreter/OptionValueArray.h lldb/include/lldb/Interpreter/OptionValueBoolean.h lldb/include/lldb/Interpreter/OptionValueChar.h lldb/include/lldb/Interpreter/OptionValueEnumeration.h lldb/include/lldb/Interpreter/OptionValueFileColonLine.h lldb/include/lldb/Interpreter/OptionValueFileSpec.h lldb/include/lldb/Interpreter/OptionValueFileSpecList.h lldb/include/lldb/Interpreter/OptionValueFormat.h lldb/include/lldb/Interpreter/OptionValueFormatEntity.h lldb/include/lldb/Interpreter/OptionValueLanguage.h lldb/include/lldb/Interpreter/OptionValuePathMappings.h lldb/include/lldb/Interpreter/OptionValueRegex.h lldb/include/lldb/Interpreter/OptionValueSInt64.h lldb/include/lldb/Interpreter/OptionValueString.h lldb/include/lldb/Interpreter/OptionValueUInt64.h lldb/include/lldb/Interpreter/OptionValueUUID.h Removed: ################################################################################ diff --git a/lldb/include/lldb/Interpreter/OptionValueArch.h b/lldb/include/lldb/Interpreter/OptionValueArch.h index 809261ef22c3..5047db775fc2 100644 --- a/lldb/include/lldb/Interpreter/OptionValueArch.h +++ b/lldb/include/lldb/Interpreter/OptionValueArch.h @@ -43,9 +43,6 @@ class OptionValueArch : public OptionValue { Status SetValueFromString(llvm::StringRef value, VarSetOperationType op = eVarSetOperationAssign) override; - Status - SetValueFromString(const char *, - VarSetOperationType = eVarSetOperationAssign) = delete; void Clear() override { m_current_value = m_default_value; diff --git a/lldb/include/lldb/Interpreter/OptionValueArray.h b/lldb/include/lldb/Interpreter/OptionValueArray.h index 4546bbb80394..14bc28404ec3 100644 --- a/lldb/include/lldb/Interpreter/OptionValueArray.h +++ b/lldb/include/lldb/Interpreter/OptionValueArray.h @@ -32,9 +32,6 @@ class OptionValueArray : public OptionValue { Status SetValueFromString(llvm::StringRef value, VarSetOperationType op = eVarSetOperationAssign) override; - Status - SetValueFromString(const char *, - VarSetOperationType = eVarSetOperationAssign) = delete; void Clear() override { m_values.clear(); diff --git a/lldb/include/lldb/Interpreter/OptionValueBoolean.h b/lldb/include/lldb/Interpreter/OptionValueBoolean.h index 1af14a4980ed..6b58eb94b826 100644 --- a/lldb/include/lldb/Interpreter/OptionValueBoolean.h +++ b/lldb/include/lldb/Interpreter/OptionValueBoolean.h @@ -33,9 +33,6 @@ class OptionValueBoolean : public OptionValue { Status SetValueFromString(llvm::StringRef value, VarSetOperationType op = eVarSetOperationAssign) override; - Status - SetValueFromString(const char *, - VarSetOperationType = eVarSetOperationAssign) = delete; void Clear() override { m_current_value = m_default_value; diff --git a/lldb/include/lldb/Interpreter/OptionValueChar.h b/lldb/include/lldb/Interpreter/OptionValueChar.h index a8ecf507a4cf..b5b39b77b9b7 100644 --- a/lldb/include/lldb/Interpreter/OptionValueChar.h +++ b/lldb/include/lldb/Interpreter/OptionValueChar.h @@ -34,9 +34,6 @@ class OptionValueChar : public OptionValue { Status SetValueFromString(llvm::StringRef value, VarSetOperationType op = eVarSetOperationAssign) override; - Status - SetValueFromString(const char *, - VarSetOperationType = eVarSetOperationAssign) = delete; void Clear() override { m_current_value = m_default_value; diff --git a/lldb/include/lldb/Interpreter/OptionValueEnumeration.h b/lldb/include/lldb/Interpreter/OptionValueEnumeration.h index 12c6473c7f1c..5ef6fa54ab82 100644 --- a/lldb/include/lldb/Interpreter/OptionValueEnumeration.h +++ b/lldb/include/lldb/Interpreter/OptionValueEnumeration.h @@ -43,9 +43,6 @@ class OptionValueEnumeration : public OptionValue { Status SetValueFromString(llvm::StringRef value, VarSetOperationType op = eVarSetOperationAssign) override; - Status - SetValueFromString(const char *, - VarSetOperationType = eVarSetOperationAssign) = delete; void Clear() override { m_current_value = m_default_value; diff --git a/lldb/include/lldb/Interpreter/OptionValueFileColonLine.h b/lldb/include/lldb/Interpreter/OptionValueFileColonLine.h index 713deea9e141..b3bb1f0e7ca2 100644 --- a/lldb/include/lldb/Interpreter/OptionValueFileColonLine.h +++ b/lldb/include/lldb/Interpreter/OptionValueFileColonLine.h @@ -31,9 +31,6 @@ class OptionValueFileColonLine : public OptionValue { Status SetValueFromString(llvm::StringRef value, VarSetOperationType op = eVarSetOperationAssign) override; - Status - SetValueFromString(const char *, - VarSetOperationType = eVarSetOperationAssign) = delete; void Clear() override { m_file_spec.Clear(); diff --git a/lldb/include/lldb/Interpreter/OptionValueFileSpec.h b/lldb/include/lldb/Interpreter/OptionValueFileSpec.h index 4fde3f6e3c8a..a71858674c0a 100644 --- a/lldb/include/lldb/Interpreter/OptionValueFileSpec.h +++ b/lldb/include/lldb/Interpreter/OptionValueFileSpec.h @@ -37,9 +37,6 @@ class OptionValueFileSpec : public OptionValue { Status SetValueFromString(llvm::StringRef value, VarSetOperationType op = eVarSetOperationAssign) override; - Status - SetValueFromString(const char *, - VarSetOperationType = eVarSetOperationAssign) = delete; void Clear() override { m_current_value = m_default_value; diff --git a/lldb/include/lldb/Interpreter/OptionValueFileSpecList.h b/lldb/include/lldb/Interpreter/OptionValueFileSpecList.h index 38773525c8db..dcf926fca8d8 100644 --- a/lldb/include/lldb/Interpreter/OptionValueFileSpecList.h +++ b/lldb/include/lldb/Interpreter/OptionValueFileSpecList.h @@ -35,9 +35,6 @@ class OptionValueFileSpecList : public OptionValue { Status SetValueFromString(llvm::StringRef value, VarSetOperationType op = eVarSetOperationAssign) override; - Status - SetValueFromString(const char *, - VarSetOperationType = eVarSetOperationAssign) = delete; void Clear() override { std::lock_guard<std::recursive_mutex> lock(m_mutex); diff --git a/lldb/include/lldb/Interpreter/OptionValueFormat.h b/lldb/include/lldb/Interpreter/OptionValueFormat.h index 5a83ff3b8983..9241ba6bb9a7 100644 --- a/lldb/include/lldb/Interpreter/OptionValueFormat.h +++ b/lldb/include/lldb/Interpreter/OptionValueFormat.h @@ -34,9 +34,6 @@ class OptionValueFormat : public OptionValue { Status SetValueFromString(llvm::StringRef value, VarSetOperationType op = eVarSetOperationAssign) override; - Status - SetValueFromString(const char *, - VarSetOperationType = eVarSetOperationAssign) = delete; void Clear() override { m_current_value = m_default_value; diff --git a/lldb/include/lldb/Interpreter/OptionValueFormatEntity.h b/lldb/include/lldb/Interpreter/OptionValueFormatEntity.h index 7c2f9fba0242..a29b7f4044b4 100644 --- a/lldb/include/lldb/Interpreter/OptionValueFormatEntity.h +++ b/lldb/include/lldb/Interpreter/OptionValueFormatEntity.h @@ -30,9 +30,6 @@ class OptionValueFormatEntity : public OptionValue { Status SetValueFromString(llvm::StringRef value, VarSetOperationType op = eVarSetOperationAssign) override; - Status - SetValueFromString(const char *, - VarSetOperationType = eVarSetOperationAssign) = delete; void Clear() override; diff --git a/lldb/include/lldb/Interpreter/OptionValueLanguage.h b/lldb/include/lldb/Interpreter/OptionValueLanguage.h index 129365296759..bf86f3c371cf 100644 --- a/lldb/include/lldb/Interpreter/OptionValueLanguage.h +++ b/lldb/include/lldb/Interpreter/OptionValueLanguage.h @@ -37,9 +37,6 @@ class OptionValueLanguage : public OptionValue { Status SetValueFromString(llvm::StringRef value, VarSetOperationType op = eVarSetOperationAssign) override; - Status - SetValueFromString(const char *, - VarSetOperationType = eVarSetOperationAssign) = delete; void Clear() override { m_current_value = m_default_value; diff --git a/lldb/include/lldb/Interpreter/OptionValuePathMappings.h b/lldb/include/lldb/Interpreter/OptionValuePathMappings.h index 6d1a0816f45b..8f58d5d935e7 100644 --- a/lldb/include/lldb/Interpreter/OptionValuePathMappings.h +++ b/lldb/include/lldb/Interpreter/OptionValuePathMappings.h @@ -31,9 +31,6 @@ class OptionValuePathMappings : public OptionValue { Status SetValueFromString(llvm::StringRef value, VarSetOperationType op = eVarSetOperationAssign) override; - Status - SetValueFromString(const char *, - VarSetOperationType = eVarSetOperationAssign) = delete; void Clear() override { m_path_mappings.Clear(m_notify_changes); diff --git a/lldb/include/lldb/Interpreter/OptionValueRegex.h b/lldb/include/lldb/Interpreter/OptionValueRegex.h index 4751a1dc27ed..d8589581e51a 100644 --- a/lldb/include/lldb/Interpreter/OptionValueRegex.h +++ b/lldb/include/lldb/Interpreter/OptionValueRegex.h @@ -32,9 +32,6 @@ class OptionValueRegex : public OptionValue { Status SetValueFromString(llvm::StringRef value, VarSetOperationType op = eVarSetOperationAssign) override; - Status - SetValueFromString(const char *, - VarSetOperationType = eVarSetOperationAssign) = delete; void Clear() override { m_regex = RegularExpression(m_default_regex_str); diff --git a/lldb/include/lldb/Interpreter/OptionValueSInt64.h b/lldb/include/lldb/Interpreter/OptionValueSInt64.h index 87917c108865..2faea04d07f9 100644 --- a/lldb/include/lldb/Interpreter/OptionValueSInt64.h +++ b/lldb/include/lldb/Interpreter/OptionValueSInt64.h @@ -46,9 +46,6 @@ class OptionValueSInt64 : public OptionValue { Status SetValueFromString(llvm::StringRef value, VarSetOperationType op = eVarSetOperationAssign) override; - Status - SetValueFromString(const char *, - VarSetOperationType = eVarSetOperationAssign) = delete; void Clear() override { m_current_value = m_default_value; diff --git a/lldb/include/lldb/Interpreter/OptionValueString.h b/lldb/include/lldb/Interpreter/OptionValueString.h index ed44dae67d1d..b9b33afd3d68 100644 --- a/lldb/include/lldb/Interpreter/OptionValueString.h +++ b/lldb/include/lldb/Interpreter/OptionValueString.h @@ -81,9 +81,6 @@ class OptionValueString : public OptionValue { Status SetValueFromString(llvm::StringRef value, VarSetOperationType op = eVarSetOperationAssign) override; - Status - SetValueFromString(const char *, - VarSetOperationType = eVarSetOperationAssign) = delete; void Clear() override { m_current_value = m_default_value; diff --git a/lldb/include/lldb/Interpreter/OptionValueUInt64.h b/lldb/include/lldb/Interpreter/OptionValueUInt64.h index 1164fb802f68..adcfaca49c98 100644 --- a/lldb/include/lldb/Interpreter/OptionValueUInt64.h +++ b/lldb/include/lldb/Interpreter/OptionValueUInt64.h @@ -43,9 +43,6 @@ class OptionValueUInt64 : public OptionValue { Status SetValueFromString(llvm::StringRef value, VarSetOperationType op = eVarSetOperationAssign) override; - Status - SetValueFromString(const char *, - VarSetOperationType = eVarSetOperationAssign) = delete; void Clear() override { m_current_value = m_default_value; diff --git a/lldb/include/lldb/Interpreter/OptionValueUUID.h b/lldb/include/lldb/Interpreter/OptionValueUUID.h index 1f663e999b9d..822dc0019851 100644 --- a/lldb/include/lldb/Interpreter/OptionValueUUID.h +++ b/lldb/include/lldb/Interpreter/OptionValueUUID.h @@ -32,9 +32,6 @@ class OptionValueUUID : public OptionValue { Status SetValueFromString(llvm::StringRef value, VarSetOperationType op = eVarSetOperationAssign) override; - Status - SetValueFromString(const char *, - VarSetOperationType = eVarSetOperationAssign) = delete; void Clear() override { m_uuid.Clear(); _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits