clayborg added inline comments.
================ Comment at: lldb/include/lldb/Core/Progress.h:19 +public: + Progress(uint64_t total, const char *format, ...) + __attribute__((format(printf, 3, 4))); ---------------- clayborg wrote: > JDevlieghere wrote: > > I'm not a fan of how we'rere-implementing printf across different utility > > classes. Can we have this take `std::string` (that we move into the > > member) and have the caller use `formatv` or something to construct the > > string? > Were are not implementing printf, just forwarding to a var args. If we switch > over to anything we should switch to ConstString since we report the same > ConstString on each callback. If we do switch to "ConstString message" can you add inline code suggestions for using formatv for one of the Progress constructors to see how it would look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97739/new/ https://reviews.llvm.org/D97739 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
