justincohen added inline comments.
================ Comment at: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp:63 + // should be removed once full PAC support is added. + return pc & 0x0000000FFFFFFFFF; +} ---------------- DavidSpickett wrote: > omjavaid wrote: > > How did you come up with this 36bit mask for PC reg I think this mask is > > not appropriate for Linux virtual address space which is 52 or 48 bits in > > length. > > > > > If it's any help I looked for this too and found > `aarch64/functions/pac/calcbottompacbit/CalculateBottomPACBit` pseudocode in > the armarm. This is used by the PAC strip instructions. (though it is a bit > mind bending to read) I'll move this to `lldb/source/Plugins/ABI/AArch64/ABIMacOSX_arm64.h` to not impact Linux. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98529/new/ https://reviews.llvm.org/D98529 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
