kimanh marked an inline comment as done. kimanh added a comment. Thanks a lot for the review Pavel! I've updated the test. If it looks fine like this, could you help me to commit this change?
================ Comment at: lldb/test/Shell/SymbolFile/DWARF/dwarf5-debug_line-file-index.s:98 + .byte 86 + .byte 3 # DW_AT_name + .byte 0 # DW_AT_decl_file ---------------- labath wrote: > I was puzzled by this line as the string 3 is nowhere to be found. I take it > this was manually reduced? If so, I think you should be able to delete the > entire subprogram and base_type tags (and the relevant abbreviations), as > that is not necessary for the line tables to work. Thanks for the guidance here! Yes, that's correct, I've manually reduced it but wasn't sure what else I could safely remove. I've now removed the subprogram parts, and the base_type tags. Hope that looks better now! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98619/new/ https://reviews.llvm.org/D98619 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
