dblaikie added a comment. @wallace - minor inconvenience, but approving a patch in Phabricator without any textual comment does not result in an email to the list, making it look like a patch is being committed without approval - could you include some text in your Phab approvals, as it makes it a bit easier when doing post-commit/process review?
@JDevlieghere Is it worth having a C++ RAII object that calls initialize in the ctor and terminate in the dtor? (maybe even removing the init/terminate free functions, and making them only accessible through an RAII object if that's suitable) What do the other uses of init/terminate look like/could they benefit from such refactoring? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99702/new/ https://reviews.llvm.org/D99702 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
