[Lldb-commits] [PATCH] D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC)

Dave Lee via Phabricator via lldb-commits Sun, 04 Apr 2021 16:08:21 -0700

kastiglione updated this revision to Diff 335187.
kastiglione added a comment.


fix lldb/test/API/commands/frame/recognizer/main.m


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99867/new/

https://reviews.llvm.org/D99867

Files:
  lldb/test/API/commands/expression/context-object-objc/Makefile
  lldb/test/API/commands/expression/context-object-objc/main.m
  lldb/test/API/commands/expression/namespace_local_var_same_name_obj_c/main.mm
  lldb/test/API/commands/frame/recognizer/Makefile
  lldb/test/API/commands/frame/recognizer/main.m
  lldb/test/API/functionalities/type_lookup/Makefile
  lldb/test/API/functionalities/type_lookup/main.mm
  lldb/test/API/lang/objc/bitfield_ivars/Makefile
  lldb/test/API/lang/objc/bitfield_ivars/main.m
  lldb/test/API/lang/objc/blocks/Makefile
  lldb/test/API/lang/objc/blocks/ivars-in-blocks.h
  lldb/test/API/lang/objc/blocks/ivars-in-blocks.m
  lldb/test/API/lang/objc/conflicting-definition/Test/Test.h
  lldb/test/API/lang/objc/forward-decl/Container.h
  lldb/test/API/lang/objc/forward-decl/Makefile
  lldb/test/API/lang/objc/forward-decl/main.m
  lldb/test/API/lang/objc/foundation/my-base.m
  lldb/test/API/lang/objc/hidden-ivars/InternalDefiner.h
  lldb/test/API/lang/objc/ivar-IMP/Makefile
  lldb/test/API/lang/objc/ivar-IMP/myclass.h
  lldb/test/API/lang/objc/ivar-IMP/myclass.m
  lldb/test/API/lang/objc/ivar-IMP/repro.m
  lldb/test/API/lang/objc/modules-objc-property/main.m
  lldb/test/API/lang/objc/modules-objc-property/myModule.h
  lldb/test/API/lang/objc/objc-ivar-offsets/Makefile
  lldb/test/API/lang/objc/objc-ivar-offsets/objc-ivar-offsets.h
  lldb/test/API/lang/objc/objc-super/Makefile
  lldb/test/API/lang/objc/objc-super/class.m
  lldb/test/API/lang/objcxx/class-name-clash/myobject.mm
  lldb/test/API/python_api/class_members/main.mm
  lldb/test/API/python_api/objc_type/Makefile
  lldb/test/API/python_api/objc_type/main.m

Index: lldb/test/API/python_api/objc_type/main.m
===================================================================
--- lldb/test/API/python_api/objc_type/main.m
+++ lldb/test/API/python_api/objc_type/main.m
@@ -1,4 +1,4 @@
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
 
 @interface Foo: NSObject
 {}
Index: lldb/test/API/python_api/objc_type/Makefile
===================================================================
--- lldb/test/API/python_api/objc_type/Makefile
+++ lldb/test/API/python_api/objc_type/Makefile
@@ -1,8 +1,5 @@
 OBJC_SOURCES := main.m
-
 CFLAGS_EXTRAS := -w
+LD_EXTRAS := -lobjc
 
-
-
-LD_EXTRAS := -framework Foundation
 include Makefile.rules
Index: lldb/test/API/python_api/class_members/main.mm
===================================================================
--- lldb/test/API/python_api/class_members/main.mm
+++ lldb/test/API/python_api/class_members/main.mm
@@ -1,4 +1,4 @@
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
 
 class Base {
 public:
Index: lldb/test/API/lang/objcxx/class-name-clash/myobject.mm
===================================================================
--- lldb/test/API/lang/objcxx/class-name-clash/myobject.mm
+++ lldb/test/API/lang/objcxx/class-name-clash/myobject.mm
@@ -1,4 +1,4 @@
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
 
 @interface MyObject : NSObject
 @end
Index: lldb/test/API/lang/objc/objc-super/class.m
===================================================================
--- lldb/test/API/lang/objc/objc-super/class.m
+++ lldb/test/API/lang/objc/objc-super/class.m
@@ -1,4 +1,4 @@
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
 
 @interface Foo : NSObject {
 }
Index: lldb/test/API/lang/objc/objc-super/Makefile
===================================================================
--- lldb/test/API/lang/objc/objc-super/Makefile
+++ lldb/test/API/lang/objc/objc-super/Makefile
@@ -1,4 +1,4 @@
 OBJC_SOURCES := class.m
-LD_EXTRAS := -lobjc -framework Foundation
+LD_EXTRAS := -lobjc
 
 include Makefile.rules
Index: lldb/test/API/lang/objc/objc-ivar-offsets/objc-ivar-offsets.h
===================================================================
--- lldb/test/API/lang/objc/objc-ivar-offsets/objc-ivar-offsets.h
+++ lldb/test/API/lang/objc/objc-ivar-offsets/objc-ivar-offsets.h
@@ -1,4 +1,5 @@
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
+#import <stdint.h>
 
 @interface BaseClass : NSObject
 {
Index: lldb/test/API/lang/objc/objc-ivar-offsets/Makefile
===================================================================
--- lldb/test/API/lang/objc/objc-ivar-offsets/Makefile
+++ lldb/test/API/lang/objc/objc-ivar-offsets/Makefile
@@ -1,4 +1,4 @@
 OBJC_SOURCES := objc-ivar-offsets.m main.m
-LD_EXTRAS := -lobjc -framework Foundation
+LD_EXTRAS := -lobjc
 
 include Makefile.rules
Index: lldb/test/API/lang/objc/modules-objc-property/myModule.h
===================================================================
--- lldb/test/API/lang/objc/modules-objc-property/myModule.h
+++ lldb/test/API/lang/objc/modules-objc-property/myModule.h
@@ -1,7 +1,7 @@
 #ifndef MYMODULE
 #define MYMODULE
 
-@import Foundation;
+@import ObjectiveC;
 
 @interface MyClass : NSObject
 - (int) propConflict;
Index: lldb/test/API/lang/objc/modules-objc-property/main.m
===================================================================
--- lldb/test/API/lang/objc/modules-objc-property/main.m
+++ lldb/test/API/lang/objc/modules-objc-property/main.m
@@ -1,4 +1,4 @@
-@import Foundation;
+@import ObjectiveC;
 @import myModule;
 
 int main() {
Index: lldb/test/API/lang/objc/ivar-IMP/repro.m
===================================================================
--- lldb/test/API/lang/objc/ivar-IMP/repro.m
+++ lldb/test/API/lang/objc/ivar-IMP/repro.m
@@ -1,4 +1,4 @@
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
 #import "myclass.h"
 
 int main() {
Index: lldb/test/API/lang/objc/ivar-IMP/myclass.m
===================================================================
--- lldb/test/API/lang/objc/ivar-IMP/myclass.m
+++ lldb/test/API/lang/objc/ivar-IMP/myclass.m
@@ -1,4 +1,4 @@
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
 #import "myclass.h"
 
 @implementation MyClass
Index: lldb/test/API/lang/objc/ivar-IMP/myclass.h
===================================================================
--- lldb/test/API/lang/objc/ivar-IMP/myclass.h
+++ lldb/test/API/lang/objc/ivar-IMP/myclass.h
@@ -1,4 +1,4 @@
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
 
 @interface MyClass : NSObject
 {}
Index: lldb/test/API/lang/objc/ivar-IMP/Makefile
===================================================================
--- lldb/test/API/lang/objc/ivar-IMP/Makefile
+++ lldb/test/API/lang/objc/ivar-IMP/Makefile
@@ -1,5 +1,5 @@
 OBJC_SOURCES := myclass.m repro.m
-LD_EXTRAS := -framework Foundation
+LD_EXTRAS := -lobjc
 
 include Makefile.rules
 
Index: lldb/test/API/lang/objc/hidden-ivars/InternalDefiner.h
===================================================================
--- lldb/test/API/lang/objc/hidden-ivars/InternalDefiner.h
+++ lldb/test/API/lang/objc/hidden-ivars/InternalDefiner.h
@@ -1,4 +1,4 @@
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
 #import <stdint.h>
 
 @interface InternalDefiner : NSObject {
Index: lldb/test/API/lang/objc/foundation/my-base.m
===================================================================
--- lldb/test/API/lang/objc/foundation/my-base.m
+++ lldb/test/API/lang/objc/foundation/my-base.m
@@ -1,4 +1,4 @@
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
 #import "my-base.h"
 @implementation MyBase
 #if __OBJC2__
Index: lldb/test/API/lang/objc/forward-decl/main.m
===================================================================
--- lldb/test/API/lang/objc/forward-decl/main.m
+++ lldb/test/API/lang/objc/forward-decl/main.m
@@ -1,5 +1,6 @@
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
 #import "Container.h"
+#import <stdio.h>
 
 int main(int argc, const char * argv[])
 {
Index: lldb/test/API/lang/objc/forward-decl/Makefile
===================================================================
--- lldb/test/API/lang/objc/forward-decl/Makefile
+++ lldb/test/API/lang/objc/forward-decl/Makefile
@@ -1,8 +1,6 @@
 DYLIB_NAME := Container
 DYLIB_OBJC_SOURCES := Container.m
 OBJC_SOURCES := main.m
+LD_EXTRAS := -lobjc
 
-
-
-LD_EXTRAS := -framework Foundation
 include Makefile.rules
Index: lldb/test/API/lang/objc/forward-decl/Container.h
===================================================================
--- lldb/test/API/lang/objc/forward-decl/Container.h
+++ lldb/test/API/lang/objc/forward-decl/Container.h
@@ -1,4 +1,4 @@
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
 
 @class ForwardDeclaredClass;
 
Index: lldb/test/API/lang/objc/conflicting-definition/Test/Test.h
===================================================================
--- lldb/test/API/lang/objc/conflicting-definition/Test/Test.h
+++ lldb/test/API/lang/objc/conflicting-definition/Test/Test.h
@@ -1,5 +1,5 @@
-#import <Foundation/Foundation.h>
 #import <Test/Foo.h>
+#import <objc/NSObject.h>
 
 @interface Test : NSObject {
 @public
Index: lldb/test/API/lang/objc/blocks/ivars-in-blocks.m
===================================================================
--- lldb/test/API/lang/objc/blocks/ivars-in-blocks.m
+++ lldb/test/API/lang/objc/blocks/ivars-in-blocks.m
@@ -1,4 +1,5 @@
 #import "ivars-in-blocks.h"
+#import <stdio.h>
 
 typedef int (^my_block_ptr_type) (int);
 
Index: lldb/test/API/lang/objc/blocks/ivars-in-blocks.h
===================================================================
--- lldb/test/API/lang/objc/blocks/ivars-in-blocks.h
+++ lldb/test/API/lang/objc/blocks/ivars-in-blocks.h
@@ -1,4 +1,4 @@
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
 
 @interface IAmBlocky : NSObject
 {
Index: lldb/test/API/lang/objc/blocks/Makefile
===================================================================
--- lldb/test/API/lang/objc/blocks/Makefile
+++ lldb/test/API/lang/objc/blocks/Makefile
@@ -1,4 +1,4 @@
 OBJC_SOURCES := ivars-in-blocks.m main.m
-LD_EXTRAS := -lobjc -framework Foundation
+LD_EXTRAS := -lobjc
 
 include Makefile.rules
Index: lldb/test/API/lang/objc/bitfield_ivars/main.m
===================================================================
--- lldb/test/API/lang/objc/bitfield_ivars/main.m
+++ lldb/test/API/lang/objc/bitfield_ivars/main.m
@@ -1,4 +1,4 @@
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
 
 typedef struct {
     unsigned char fieldOne : 1;
Index: lldb/test/API/lang/objc/bitfield_ivars/Makefile
===================================================================
--- lldb/test/API/lang/objc/bitfield_ivars/Makefile
+++ lldb/test/API/lang/objc/bitfield_ivars/Makefile
@@ -1,4 +1,4 @@
 OBJC_SOURCES := main.m
-LD_EXTRAS = -framework Foundation
+LD_EXTRAS = -lobjc
 
 include Makefile.rules
Index: lldb/test/API/functionalities/type_lookup/main.mm
===================================================================
--- lldb/test/API/functionalities/type_lookup/main.mm
+++ lldb/test/API/functionalities/type_lookup/main.mm
@@ -1,4 +1,4 @@
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
 
 class MyCPPClass {
 public:
Index: lldb/test/API/functionalities/type_lookup/Makefile
===================================================================
--- lldb/test/API/functionalities/type_lookup/Makefile
+++ lldb/test/API/functionalities/type_lookup/Makefile
@@ -1,8 +1,5 @@
 OBJCXX_SOURCES := main.mm
-
 CFLAGS_EXTRAS := -w
+LD_EXTRAS := -lobjc
 
-
-
-LD_EXTRAS := -framework Foundation
 include Makefile.rules
Index: lldb/test/API/commands/frame/recognizer/main.m
===================================================================
--- lldb/test/API/commands/frame/recognizer/main.m
+++ lldb/test/API/commands/frame/recognizer/main.m
@@ -1,4 +1,4 @@
-#import <Foundation/Foundation.h>
+#import <stdio.h>
 
 void foo(int a, int b)
 {
Index: lldb/test/API/commands/frame/recognizer/Makefile
===================================================================
--- lldb/test/API/commands/frame/recognizer/Makefile
+++ lldb/test/API/commands/frame/recognizer/Makefile
@@ -1,9 +1,5 @@
 OBJC_SOURCES := main.m
-
 CFLAGS_EXTRAS := -g0 # No debug info.
 MAKE_DSYM := NO
 
-
-
-LD_EXTRAS := -framework Foundation
 include Makefile.rules
Index: lldb/test/API/commands/expression/namespace_local_var_same_name_obj_c/main.mm
===================================================================
--- lldb/test/API/commands/expression/namespace_local_var_same_name_obj_c/main.mm
+++ lldb/test/API/commands/expression/namespace_local_var_same_name_obj_c/main.mm
@@ -1,4 +1,4 @@
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
 @interface Util : NSObject
 + (void)debugPrintErrorStatic;
 - (void)debugPrintError;
Index: lldb/test/API/commands/expression/context-object-objc/main.m
===================================================================
--- lldb/test/API/commands/expression/context-object-objc/main.m
+++ lldb/test/API/commands/expression/context-object-objc/main.m
@@ -1,4 +1,4 @@
-#import <Foundation/Foundation.h>
+#import <objc/NSObject.h>
 
 @interface ObjcClass : NSObject {
     int field;
Index: lldb/test/API/commands/expression/context-object-objc/Makefile
===================================================================
--- lldb/test/API/commands/expression/context-object-objc/Makefile
+++ lldb/test/API/commands/expression/context-object-objc/Makefile
@@ -1,3 +1,4 @@
 OBJC_SOURCES := main.m
-LD_EXTRAS := -framework Foundation
+LD_EXTRAS := -lobjc
+
 include Makefile.rules

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC)

Reply via email to