teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land.
LGTM now beside the now redundant import ================ Comment at: lldb/test/API/functionalities/memory/read/TestMemoryRead.py:7 import lldbsuite.test.lldbutil as lldbutil +import tempfile + ---------------- No longer needed ================ Comment at: lldb/test/API/functionalities/memory/read/TestMemoryRead.py:168 + with open(memory_read_file, 'w') as f: + f.write("some garbage") + ---------------- I see you have taken my suggestion literally CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99890/new/ https://reviews.llvm.org/D99890 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits