labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
cool ================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:835 + // Parse client-indicated features. + llvm::StringRef view = packet.GetStringRef(); + llvm::SmallVector<llvm::StringRef, 4> client_features; ---------------- remove variable used only once? ================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1310-1311 + "QStartNoAckMode+", + "QThreadSuffixSupported+", + "QListThreadsInStopReply+", + "qEcho+", ---------------- I think that these two should also be llgs-specific. ================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h:151 + virtual std::vector<std::string> + HandleFeatures(const llvm::ArrayRef<llvm::StringRef> client_features); + ---------------- this `const` is useless CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100140/new/ https://reviews.llvm.org/D100140 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
