mgorny added inline comments.

================
Comment at: 
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2102
+  if (pid == StringExtractorGDBRemote::AllProcesses)
+    return SendUnimplementedResponse("Selecting all processes not supported");
+  if (pid == LLDB_INVALID_PROCESS_ID)
----------------
labath wrote:
> Does it ever make sense to have more than one (process or thread) selected? 
> If not, an error response may be more appropriate..
Good question.

As for PID, I don't think that the client would do something like that within 
foreseeable future.

However, sending all-TIDs are technically supported in our LLGS client code. I 
don't know whether it's actually used anywhere, though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100261/new/

https://reviews.llvm.org/D100261

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to