This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2da1f68d815: Get Section from resolved_addr in Target::ReadMemory (authored by jasonmolenda).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100850/new/ https://reviews.llvm.org/D100850 Files: lldb/source/Target/Target.cpp Index: lldb/source/Target/Target.cpp =================================================================== --- lldb/source/Target/Target.cpp +++ lldb/source/Target/Target.cpp @@ -1756,7 +1756,7 @@ bool is_readonly = false; // Read from file cache if read-only section. if (!force_live_memory && resolved_addr.IsSectionOffset()) { - SectionSP section_sp(addr.GetSection()); + SectionSP section_sp(resolved_addr.GetSection()); if (section_sp) { auto permissions = Flags(section_sp->GetPermissions()); is_readonly = !permissions.Test(ePermissionsWritable) &&
Index: lldb/source/Target/Target.cpp =================================================================== --- lldb/source/Target/Target.cpp +++ lldb/source/Target/Target.cpp @@ -1756,7 +1756,7 @@ bool is_readonly = false; // Read from file cache if read-only section. if (!force_live_memory && resolved_addr.IsSectionOffset()) { - SectionSP section_sp(addr.GetSection()); + SectionSP section_sp(resolved_addr.GetSection()); if (section_sp) { auto permissions = Flags(section_sp->GetPermissions()); is_readonly = !permissions.Test(ePermissionsWritable) &&
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits