teemperor added inline comments.
================ Comment at: lldb/source/Plugins/InstrumentationRuntime/MainThreadChecker/InstrumentationRuntimeMainThreadChecker.cpp:273 + ThreadSP new_thread_sp = std::make_shared<HistoryThread>( + *process_sp, tid, PCs, pcs_are_call_addresses); ---------------- shafik wrote: > A nitpick but you could have also done: > > ``` > ThreadSP new_thread_sp = std::make_shared<HistoryThread>( > *process_sp, tid, PCs, true /*pcs_are_call_addresses*/); > > ``` > > Otherwise I would have made `pcs_are_call_addresses` a constant since you are > using purely for documentation. I think the format `/*pc_are_call_addresses=*/true);` is what LLVM is using (with that format clang-tidy will check that the argument fits the parameter name). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101094/new/ https://reviews.llvm.org/D101094 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
