thopre added a comment.

In D102630#2764705 <https://reviews.llvm.org/D102630#2764705>, @dblaikie wrote:

> @thopre - as an aside: It'd be helpful if you could include some text in the 
> text box when marking something "approved" through phabricator. There's a 
> bug/limitation that approvals without text don't produce email to the mailing 
> list - so it looks like a patch hasn't been reviewed yet (or has been 
> committed without review).

Oh sorry, I was not aware of that limitation. Will be careful to include a 
message in the future


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102630/new/

https://reviews.llvm.org/D102630

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to